HDFS-15855.Solve the problem of incorrect EC progress when loading FsImage.#2741
HDFS-15855.Solve the problem of incorrect EC progress when loading FsImage.#2741jianghuazhu wants to merge 1 commit intoapache:trunkfrom
Conversation
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
as far as I know there aren't supposed to be too many EC policies to load. But it's a nice-to-have nevertheless.
|
According to Jenkins the only test that failed was TestBalancer, which is unrelated to this patch. |
|
@jojochuang , thanks for your comment. |
There was a problem hiding this comment.
Can you leave the old header passing a null so we don't need to modify the tests?
There was a problem hiding this comment.
+1, keep the original method and parameters as followinng.
public synchronized void loadPolicies( List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf) { loadPolicies(ecPolicies, conf, null); }
There was a problem hiding this comment.
Can we add a test with the counter being passed?
|
@goiri , thanks for your comment. I will add some unit tests. |
Hexiaoqiao
left a comment
Hexiaoqiao
left a comment
There was a problem hiding this comment.
It almost looks good to me, will give +1 from my side when add new unit test to cover the ecpolicy counter. Thanks @jianghuazhu for your works.
There was a problem hiding this comment.
+1, keep the original method and parameters as followinng.
public synchronized void loadPolicies( List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf) { loadPolicies(ecPolicies, conf, null); }
|
@Hexiaoqiao , @jojochuang , I have submitted a new solution. |
|
💔 -1 overall
This message was automatically generated. |
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
5 participants
…Image.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute